Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for ggml generator #618

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

jmartin-tech
Copy link
Collaborator

  • Adds test for GGML initialization validation
  • Refactors pyproject.toml to make dev and test dependencies optional
    • Add pyproject.toml optional-dependencies section
    • Add # comment line support for requirements.txt in validation test
    • Update validation test to include optional-dependencies

Item to consider here, should the dependencies validation test be revised to validate sections noted in requirements.txt are consistent with pyproject.toml? Having asked this I posit the value for the changes is in pyproject.toml no longer requiring dev or test dependencies during a pip install garak and sections in requirements.txt is just syntactic sugar.

Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
Copy link
Owner

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of questions

tests/generators/test_ggml.py Outdated Show resolved Hide resolved
tests/generators/test_ggml.py Outdated Show resolved Hide resolved
Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
@leondz leondz merged commit 148f0f1 into leondz:main Apr 23, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants