Enforce warning output for garak classes.
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change raises lib warnings more clearly and has an effect of suppressing warnings from dependency classes. While not optimal, the explicit check for warnings from repo code is a reasonable trade off. A separate maintenance action should be added in a future iteration to add checks for warnings introduced when updating dependency versions. Signed-off-by: Jeffrey Martin <jemartin@nvidia.com>
leondz
approved these changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of the
litellmpackage caused test runs to report warnings about pending deprecations in dependency code not directly in scope of this project.This change raises lib warnings more clearly and has an effect of suppressing warnings from dependency classes. While not optimal, the explicit check for warnings from repo code is a reasonable trade off.
A separate maintenance action should be added in a future iteration to add checks for warnings introduced when updating dependency versions.
The changes to lib files resolve warnings primarily related file handles that are opened and never closed. Changes to the tests may be be worth an extended look as most are related to not closing the
_config.TransientConfig.reportfilewhen the object is reloaded or goes out of scope.