Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choose whether buffing will also include the original prompt #523

Merged
merged 5 commits into from
Feb 28, 2024
Merged

choose whether buffing will also include the original prompt #523

merged 5 commits into from
Feb 28, 2024

Conversation

leondz
Copy link
Owner

@leondz leondz commented Feb 27, 2024

addresses #373

erickgalinkin
erickgalinkin previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@erickgalinkin erickgalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments around avoiding naming collisions and some color commentary but I think we're good to merge as-is.

garak/command.py Outdated Show resolved Hide resolved
garak/resources/garak.core.yaml Show resolved Hide resolved
tests/buffs/test_buff_config.py Outdated Show resolved Hide resolved
tests/buffs/test_buff_config.py Outdated Show resolved Hide resolved
tests/buffs/test_buff_config.py Show resolved Hide resolved
@leondz leondz merged commit f410074 into main Feb 28, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@leondz leondz deleted the feature/buffs_skip_source branch February 28, 2024 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erickgalinkin erickgalinkin erickgalinkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leondz @erickgalinkin