Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post buff hook #506

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add post buff hook #506

merged 1 commit into from
Feb 21, 2024

Conversation

erickgalinkin
Copy link
Collaborator

Add untransform to buffs.base (placeholder) and low_resource_languages.py. Add post_buff_hook state tracking in Probe base class to flag the need to call _postprocess_buff, which calls buff.untransform on the attempt.

…s.py. Add post_buff_hook state tracking in Probe base class to flag the need to call _postprocess_buff, which calls buff.untransform on the attempt.
@erickgalinkin erickgalinkin linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link
Owner

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leondz leondz merged commit f2ec5d9 into main Feb 21, 2024
5 checks passed
@leondz leondz deleted the translate-buff-hook branch February 21, 2024 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buffs: lrl translate buff should translate output back
2 participants