Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI upgrade #477

Merged
merged 2 commits into from
Feb 15, 2024
Merged

OpenAI upgrade #477

merged 2 commits into from
Feb 15, 2024

Conversation

erickgalinkin
Copy link
Collaborator

Update gitignore. Upgrade openai to version 1.12.0 and refactor OpenAIGenerator to handle new calling conventions. Add test_openai.py.

@erickgalinkin
Update gitignore. Upgrade openai to version 1.12.0 and refactor OpenA…
0c490a9 
…IGenerator to handle new calling conventions. Add test_openai.py.
@erickgalinkin erickgalinkin linked an issue Feb 14, 2024 that may be closed by this pull request
move to new openai API #301
Closed
leondz
leondz approved these changes Feb 15, 2024
View reviewed changes
Copy link
Owner

@leondz leondz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  • both pyproject.toml and requirements.txt need to have the requirements in them. this should be caught by a test but that test wasn't in this commit, maybe you need to do a pull?

@leondz leondz merged commit df0c8c4 into leondz:main Feb 15, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leondz leondz leondz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move to new openai API
2 participants
@erickgalinkin @leondz