Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve git URL parsing #70

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Improve git URL parsing #70

merged 2 commits into from
Dec 3, 2022

Conversation

Benricheson101
Copy link
Contributor

Trims the whitespace off the git remote URL so git-url-parse doesn't throw an error, and prevents .git from being removed from the middle of a URL.

@xhayper
Copy link
Collaborator

xhayper commented Dec 3, 2022

Amazing work!

@xhayper xhayper merged commit afe16d5 into leonardssh:main Dec 3, 2022
@xhayper
Copy link
Collaborator

xhayper commented Dec 3, 2022

I will get this patch out to vscord too, you will be credited <3

@Benricheson101 Benricheson101 deleted the fix/git-url branch December 3, 2022 01:30
@xhayper xhayper added the enhancement New feature or request label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Benricheson101 @xhayper