Bringing deno-amqp up-to-date and further #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 14, 2024 00:12
lenkan
reviewed
Apr 14, 2024
There was a problem hiding this comment.
Amazing. Thanks for this. I have not been using this myself in a while so contributions like this are very welcome.
I believe you need to upgrade the deno version in the workflow so that the tests pass:
deno-amqp/.github/workflows/ci.yml
Line 24 in a088dff
If you want, you can add a matrix for the supported versions.
nashaddams
force-pushed
the
request-for-contribution
branch
from
b2f0cf6
to
56f7fd5
Compare
lenkan
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been using your lib extensively in a production environment and would like offer my contribution. In a fork I added some changes to adhere to the current Deno version. I'm looking forward to your feedback.