[Bugfix] Fix encoder_name param while initialising Client
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Make `encoder_name` work again 2. Add `codec_name` param to work with encoder_name
aentwist
reviewed
Sep 7, 2024
| ] | ||
| print(commands) |
aentwist
added a commit
to aentwist/py-scrcpy-client
that referenced
this pull request
Sep 7, 2024
aentwist
added a commit
to aentwist/py-scrcpy-client
that referenced
this pull request
Sep 7, 2024
aentwist
added a commit
to aentwist/py-scrcpy-client
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation:
I noticed that
encoder_namearguments in constructor ofscrcpy.Clienthas been broken since the update for supportingscrcpy2.4. However, I have the requirement to force server to use h264 encoder and codec so as to make it work properly. Therefore, I make these changes.Changes:
encoder_namework againcodec_nameparam to work with encoder_nameencoder_name(default toOMX.google.h264.encoder),codec_name(default toh264)