Fix ci #61
Merged
Fix ci #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Investigating the flake8 issue Edit: https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean I decided to just upgrade it from 4 to 7, which did the trick. This caused the required python min version to raise from 3.8.0 to 3.8.1 |
Upgrade flake8 from 4 to 7. This upgrades pycodestyle. It also upgrades pyflakes from 2 to 3. BREAKING CHANGE: Upgrade the minimum Python version from 3.8.0 to 3.8.1
|
@leng-yue , I hate to bother you so much but would you mind retrying the pipeline on main? It looks like it randomly died, from what appears to hopefully be a network error. I need to make sure there is nothing else I need to fix 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this shores up the CI. What do you think @leng-yue ?
Besides fixing the python version inconsistencies I created, I think the python 3.7 macos-latest job failed because of this: actions/setup-python#808
It looks like a new macos-latest was introduced that didn't have support for python <3.10. In the issue they mention it should be supported now, but they don't really talk about anything less than 3.8. Fortunately, that's our new minimum.
Although it might not be necessary, I hope that upgrading the setup-python actions to v5 guarantees this is fixed. My understanding of that is very surface level, but hopefully I don't need to go any deeper.