Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play nice with 0.29.2 on both platforms again. #406

Closed
wants to merge 3 commits into from
Closed

Play nice with 0.29.2 on both platforms again. #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60111e5
Fixes 2 no-compile issues that suddenly popped up in iOS.
skellock Jul 18, 2016
9927f45
Targets the current React Native.
skellock Jul 19, 2016
1b30938
Instructs link on where to point to.
skellock Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ android {
}

dependencies {
compile 'com.facebook.react:react-native:0.29.0'
compile 'com.facebook.react:react-native:+'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been discussed a lot in other issues, tl;dr: just revert it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured this would be a no go. Is there a way we can make this library survive React Native upgrades without it though?

compile "com.google.android.gms:play-services-base:8.4.0"
compile 'com.google.android.gms:play-services-maps:8.4.0'
}
1 change: 0 additions & 1 deletion ios/AirMaps/AIRMap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#import <MapKit/MapKit.h>
#import <UIKit/UIKit.h>
#import <React/RCTComponent.h>

#import "RCTConvert+MapKit.h"
#import "RCTComponent.h"
Expand Down
2 changes: 1 addition & 1 deletion ios/AirMaps/AIRMapCallout.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//

#import <Foundation/Foundation.h>
#import "React/RCTView.h"
#import "RCTView.h"


@interface AIRMapCallout : RCTView
Expand Down
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,10 @@
"devDependencies": {
"react": "15.2.0",
"react-native": "0.29.0"
},
"rnpm": {
"android": {
"sourceDir": "./android/lib"
}
}
}