-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SearchFiltersPanel into kolibri-common #12669
Move SearchFiltersPanel into kolibri-common #12669
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moves SearchFiltersPanel component into kolibri-common, together with all children components that support it
This has moved all the components into the JS coreAPI, not into the kolibri-common
package - this can be found in packages/kolibri-common
.
Will need to reconcile the SidePanelModal in learn with the copy that was made into kolibri-common previously also.
@@ -66,15 +66,14 @@ | |||
import commonCoreStrings from 'kolibri.coreVue.mixins.commonCoreStrings'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's already a copy of the SidePanelModal in kolibri-common, but it may have been altered. This may require some reconciliation to have it work as expected here and elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a small tweak iin one of the learn elements this SidePanelModal can be used here too without more changes. Done!
ceec415
to
901e701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
489c671
to
411b864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No regressions observed now!
Summary
Screenshot checking search, translations and info panel:
References
Closes: #12519
Reviewer guidance
Check all tasks described at #12519 are implemented
Check tests pass
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)