Bump kolibri-design-system from 5.0.0-rc3 to 5.0.0-rc5 #12651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://github.com/avatars/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
javascript
Build Artifacts
|
|
Regarding https://github.com/search?q=repo%3Alearningequality%2Fkolibri%20appendToRoot&type=code |
9 tasks
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/kolibri-design-system-5.0.0-rc5
branch
4 times, most recently
from
17f9da0
to
eeac05e
Compare
10 tasks
|
|
github-actions
bot
added
the
APP: Learn
|
Thanks a lot @nucleogenesis, code changes make sense to me. I think after QA you mentioned earlier, we should be ready for merge. Thanks for jumping in to support this. |
|
Hi @nucleogenesis - no issues observed while testing the selection on the user table, everything is working as expected. |
MisRob
approved these changes
Sep 25, 2024
Bumps [kolibri-design-system](https://github.com/learningequality/kolibri-design-system) from 5.0.0-rc3 to 5.0.0-rc5. - [Release notes](https://github.com/learningequality/kolibri-design-system/releases) - [Changelog](https://github.com/learningequality/kolibri-design-system/blob/develop/CHANGELOG.md) - [Commits](learningequality/kolibri-design-system@v5.0.0-rc3...v5.0.0-rc5) --- updated-dependencies: - dependency-name: kolibri-design-system dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…kbox KCheckbox no longer maintains its own internal state, rather, it is just like a fancy button which emits an event that it's been clicked and the parent component must react and update the value it passes to `checked` or `indeterminate` accordingly. These tests rely on KCheckbox to emit its internal state whenever it emits `change` and that no longer is the case given KCheckbox doesn't keep an internal state. I've tweaked some of the conditionals in UserTable that relied on that emitted `checked` value so that they instead get the same information from existing available values.
nucleogenesis
force-pushed
the
dependabot/npm_and_yarn/kolibri-design-system-5.0.0-rc5
branch
from
3f36ea9
to
d5ddd80
Compare
dependabot
bot
deleted the
dependabot/npm_and_yarn/kolibri-design-system-5.0.0-rc5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps kolibri-design-system from 5.0.0-rc3 to 5.0.0-rc5.
Release notes
Sourced from kolibri-design-system's releases.
Changelog
Sourced from kolibri-design-system's changelog.
... (truncated)
Commits
dd13ea6Update CHANGELOG.md for PR #77647c955eMerge pull request #776 from AlexVelezLl/release-v5-prep726b206Bump KDS version to 5.0.0-rc5b2946feUpdate CHANGELOG.md for PR #727754f629Merge pull request #727 from BabyElias/gsoc-table-develop7acfa97passed textAlign to KTableGridItemd41aef2changelog.md reverted90bd023fixed linting errors34dcfbcCleaned up playground pageeb923d2Added header align same as content alignmentDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)