refactor: use searchLCtx in sym_aggregate #201
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
force-pushed
the
refactor-state-monads-7
branch
from
b23f78c
to
af92c68
Compare
alexkeizer
force-pushed
the
refactor-state-monads-6
branch
from
6a6a671
to
9b186cb
Compare
alexkeizer
force-pushed
the
refactor-state-monads-7
branch
from
af92c68
to
99b1adc
Compare
shigoel
reviewed
Sep 30, 2024
| return axHyps | ||
| -- `r ?field ?state = ?rhs` | ||
| searchLCtxFor (whenFound := whenFound) | ||
| (matchUnderBinders := true) |
There was a problem hiding this comment.
Comment -- why is this necessary, etc.?
shigoel
reviewed
Sep 30, 2024
| let expectedAlign : MetaM Expr := do | ||
| let state ← mkFreshExprMVar mkArmState | ||
| return mkApp (mkConst ``CheckSPAlignment) state | ||
| let ((), axHyps) ← StateT.run (s := #[]) <| |
There was a problem hiding this comment.
Some explanation for the nonsavvy devs would be good.
shigoel
reviewed
Sep 30, 2024
| - If `changeType` is set to true, then we change the type of every successful | ||
| match (i.e., `whenFound` returns `continu` or `done`) to be exactly the | ||
| `expectedType` | ||
| - If `changeType` (default `false`) is set to true, then we change the type of |
There was a problem hiding this comment.
@alexkeizer Please change the SymContext to also set matchUnderBinders to true to pick up on non-effects.
alexkeizer
force-pushed
the
refactor-state-monads-6
branch
from
02e3456
to
b95fe25
Compare
Setting this option to true will make the search procedure call `forallMetaTelescope` on each type before matching.
alexkeizer
force-pushed
the
refactor-state-monads-7
branch
from
d301671
to
ecfa1df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stacked on #200.
This uses the
searchLCtxmachinery we built in #189 insym_aggregate's implementation.For now, this searches for exactly the same kind of expressions as before, but this makes it much easier to expand this set in the next PR.
Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.