Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust big segments logic to prevent duplicate polls. #225

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: Adjust big segments logic to prevent duplicate polls. #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
236e96a
fix: Adjust big segments logic to prevent duplicate polls.
kinyoklion May 31, 2024
d9d83c1
Remove debug code.
kinyoklion May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkgs/sdk/server/src/Internal/BigSegments/BigSegmentStoreWrapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ internal class BigSegmentStoreWrapper : IDisposable
private readonly CancellationTokenSource _pollCanceller;
private readonly ReaderWriterLockSlim _lock = new ReaderWriterLockSlim();
private readonly Logger _logger;
private readonly Task<BigSegmentStoreStatus> _initialPoll;

private BigSegmentStoreStatus? _lastStatus;

Expand All @@ -43,8 +44,9 @@ Logger logger
_taskExecutor = taskExecutor;
_logger = logger;

_initialPoll = Task.Run(PollStoreAndUpdateStatusAsync);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually run the first task instead of using the repeating task.

_pollCanceller = taskExecutor.StartRepeatingTask(
TimeSpan.Zero,
config.StatusPollInterval,
config.StatusPollInterval,
PollStoreAndUpdateStatusAsync
);
Expand Down Expand Up @@ -119,11 +121,7 @@ internal BigSegmentStoreStatus GetStatus()
{
_lock.ExitReadLock();
}
if (ret.HasValue)
{
return ret.Value;
}
return AsyncUtils.WaitSafely(() => PollStoreAndUpdateStatusAsync());
return ret ?? _initialPoll.GetAwaiter().GetResult();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no value, then that first poll has not completed. Wait for it to complete.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that the initial task is still executing by the time the first repeating task runs? I suppose it may be extremely unlikely given the real world values of StatusPollInterval.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It theoretically is possible. I did consider if there was a way to use the most recent task, but the complexity didn't seem worth it. If at any point a repeating task does complete, then we would ideally hit the first code path subsequently.

}

private async Task<BigSegmentStoreStatus> PollStoreAndUpdateStatusAsync()
Expand Down