Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Run contract tests on windows. #221

Merged
merged 4 commits into from
May 24, 2024
Merged

chore: Run contract tests on windows. #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6bb3f7
chore: Run contract tests on windows.
kinyoklion May 23, 2024
88f7563
Extra slash for parameter.
kinyoklion May 23, 2024
cdba822
Dash instead.
kinyoklion May 23, 2024
59e9dac
Lowercase debug.
kinyoklion May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/contract-tests/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:

- name: Build Contract Tests
shell: bash
run: dotnet build /p:Configuration=debug ${{ inputs.service_project_file }}
run: dotnet build -p:Configuration=debug ${{ inputs.service_project_file }}

- name: Launch Contract Tests
id: launch-contract-tests
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/sdk-server-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ jobs:
project_file: pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj
test_project_file: pkgs/sdk/server/test/LaunchDarkly.ServerSdk.Tests.csproj

# Running contract tests on windows is currently cumbersome.
# Once that has been addressed, then running contract tests on windows should be considered.
- uses: ./.github/actions/contract-tests
if: ${{ matrix.os != 'windows-latest' }}
with:
service_project_file: pkgs/sdk/server/contract-tests/TestService.csproj
service_dll_file: pkgs/sdk/server/contract-tests/bin/debug/net6.0/ContractTestService.dll
Expand Down