-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
triggers watchdog #127
Comments
Dug a bit into it and: In src/AppleMIDI.hpp there's (line 27):
But 'parse' can also return parserReturn::NotSureGiveMeMoreData (and others) causing the loop to loop forever which then triggers the wdt. It doesn't explain why it fails to communicate with https://github.com/davidmoreno/rtpmidid though. |
additional test to avoid infinite loop (added in master branch, tested on ESP32) Arduino-AppleMIDI-Library/src/AppleMIDI.hpp Lines 32 to 38 in 17a1b7b
@folkertvanheusden does this resolve this issue? |
@folkertvanheusden thank you reporting and proactive digging into the issue |
The one from the branch I responded last on worked fine. Haven't tested the
merged version yet.
…On Sat, Aug 21, 2021 at 9:03 PM lathoub ***@***.***> wrote:
additional test to avoid infinite loop (added in master branch, tested on
ESP32)
https://github.com/lathoub/Arduino-AppleMIDI-Library/blob/17a1b7bc3223ad9edb2ea4c0f2edd2a3f2b7fe62/src/AppleMIDI.hpp#L32-L38
@folkertvanheusden <https://github.com/folkertvanheusden> does this
resolve this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUN5IW6BIFCFXDJWFFV2BATT57Z6DANCNFSM5BOGLDCQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
That did not have the fix yet :-) |
The master? Or the branch?
The branch works fine with long- and short names.
…On Sat, Aug 21, 2021 at 9:09 PM lathoub ***@***.***> wrote:
The one from the branch I responded last on worked fine. Haven't tested the merged version yet.
That did not have the fix yet :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Only 1 branch now: master |
I did another fix: the session name of the data invitation was incorrect: it send back the remote session name, rather than the local name. Maybe that addresses the below issue:
|
Hi,
I believe it may need a few calls to yield() here and there.
I took the basic ESP8266_NoteOnOffEverySec.ino, added mDNS and as soon as something connects to it, the watchdog gets triggered:
esp8266_test.zip
The text was updated successfully, but these errors were encountered: