[3.x] Fetch reset token explicitly. #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a route like the following,
$token
inshowResetForm(Request $request, $token = null)
will give the value of{subdomain}
and not{token}
because route parameters are injected based on their order.This pull request proposes that the token is explicitly fetched by name to avoid this.
I have submitted this to the master branch because it could break sites that do not use
Auth::routes()
where{token}
is the standard parameter name.