Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix delayed until on pending jobs screen #907

Merged
merged 1 commit into from
Oct 9, 2020
Merged

[5.x] Fix delayed until on pending jobs screen #907

merged 1 commit into from
Oct 9, 2020

Conversation

paras-malhotra
Copy link
Contributor

@paras-malhotra paras-malhotra commented Oct 9, 2020

Fixes #906

I've confirmed this is a bug in 5.x as well. The issue is that PendingDispatch::delay accepts an int or DateTime. The current Horizon code assumes that it's always a date. This PR fixes that. I've checked it on my PC.

Steps to reproduce:

  1. Execute TestJob::dispatch(...)->delay(60*60*24);
  2. Go to the pending jobs screen. On the index screen, it shows "delayed for a few seconds" (as tooltip) and on the job detail screen, it shows Delayed Until as the current time.

@taylorotwell taylorotwell merged commit d6d65a8 into laravel:5.x Oct 9, 2020
@paras-malhotra paras-malhotra deleted the fix_delayed_until branch October 9, 2020 21:07
@stefanbauer
Copy link

Thanks for fixing it @paras-malhotra 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delayed job shows always in horizon the current timestamp
3 participants