[5.0] Check if parent is still running #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Mar 16, 2021
| @@ -176,7 +184,8 @@ public function __construct($name, | |||
| $force = false, | |||
| $nice = 0, | |||
| $balanceCooldown = 3, | |||
| $balanceMaxShift = 1) | |||
| $balanceMaxShift = 1, | |||
| $parentId = 0) | |||
There was a problem hiding this comment.
@halaei why didn't you implement this argument? Atm it'll always be zero.
There was a problem hiding this comment.
Sorry @driesvints It seems I made a mistake. Setting parentId in constructor also doesn't work because it is still zero in ensureParentIsRunning.
There was a problem hiding this comment.
@halaei what do you mean? If we fix this by passing the $parentId from the constructor to the property it should work, no? Why do you think it would still be zero?
There was a problem hiding this comment.
@driesvints I just dump() the value! It was 0 for sure. I sent a draft PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if horizon process gets terminated by SIGKILL, supervisor processes must be killed by kill command, or they will be provisioning workers for ever. There is no artisan command to terminate orphan supervisors, so it is a little bit of trouble.
If you want to see if you have orphan supervisors in your production, you can use the following command:
This PR lets the orphan supervisors check for their parent process id at the beginning of their loop, so they can terminate in case their parent,
php artisan horizon, is no longer running.