Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Implement default environment #869

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Conversation

driesvints
Copy link
Member

This PR implements a default environment for Horizon. Any other environment will re-use this default environment's settings which can be overridden. Supported environments still need to be defined but this helps with the maintenance burden of having to maintain duplicate settings for multiple environments.

I've updated the config file which immediately shows how this can be useful.

Sent to master because it's obviously breaking for anyone who was relying on the current formatting of the config.

Closes #438

@driesvints
Copy link
Member Author

driesvints commented Aug 6, 2020

Additional options for this PR are:

  • Move the defaults out of the environments array into a separate config option (might be more clearer)
  • Don't require environments to be defined in the array and use the default one when one cannot be found

@taylorotwell taylorotwell merged commit 1cd5d78 into master Aug 10, 2020
@driesvints driesvints deleted the default-environment branch August 10, 2020 14:52
@hivokas
Copy link
Contributor

hivokas commented Aug 12, 2020

Thanks @driesvints! That's a very useful feature.

@setkyar
Copy link
Contributor

setkyar commented Jan 7, 2021

Hi @driesvints , I added the documentation for this PR. Since it's confusing for people who use multiple supervisors and the default queues are on there. Please help check and help me add comments if I can improve on the documentation.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants