Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Chronos 2.0 #824

Merged
merged 3 commits into from
Apr 13, 2020
Merged

[4.x] Chronos 2.0 #824

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1394abd
Chronos 2.0
sojeda Apr 13, 2020
a769a1b
Chronos 1 Â| Chronos 2
sojeda Apr 13, 2020
1298055
Revert Changes
sojeda Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"ext-json": "*",
"ext-pcntl": "*",
"ext-posix": "*",
"cakephp/chronos": "^1.0",
"cakephp/chronos": "^1.0|^2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this later on? I think the bump to just ^2.0 is perfectly fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case there are projects that use version 1

Copy link
Member

@driesvints driesvints Apr 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those projects need to define the chronos dependency in their own composer.json if they depend on it directly. We're changing the dependency for Horizon here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I leave it like it was before

"illuminate/contracts": "^7.0",
"illuminate/queue": "^7.0",
"illuminate/support": "^7.0",
Expand Down