[4.x] Chronos 2.0 #824
Merged
[4.x] Chronos 2.0 #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it's fine to do this since the tests are passing. |
driesvints
previously approved these changes
Apr 13, 2020
driesvints
reviewed
Apr 13, 2020
composer.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| "ext-json": "*", | |||
| "ext-pcntl": "*", | |||
| "ext-posix": "*", | |||
| "cakephp/chronos": "^1.0", | |||
| "cakephp/chronos": "^1.0|^2.0", | |||
There was a problem hiding this comment.
Why did you change this later on? I think the bump to just ^2.0 is perfectly fine.
There was a problem hiding this comment.
In case there are projects that use version 1
There was a problem hiding this comment.
Those projects need to define the chronos dependency in their own composer.json if they depend on it directly. We're changing the dependency for Horizon here.
There was a problem hiding this comment.
Ok, I leave it like it was before
driesvints
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#823