Allow Horizon to be used on a subdomain without a subfolder #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use it instead of Horizon.path
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just started on a project where I'd like to use Nova in the root of the
adminsubdomain, Telescope on thetelescopesubdomain and Horizon on thehorizonsubdomain. Nova and Telescope can handle this without issues, but Horizon ended up linking to URLs likehttps://monitoringwhendomainwas set tohorizon.domain.comandpathwas set to/in the config file.So, I looked at the Horizon and Telescope codebases, figured out why Telescope could handle these config settings and then just added those Telescope bits to Horizon.
Would be great if you could merge this. Cheers!