-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Handle configured 'trim' values in dashboard #461
Conversation
This looks good but perhaps something more for 3.0 because the new methods on the |
Per @driesvints' comments above, I've rewritten this to be done in the |
This is much needed, had a bash at this myself a couple of months ago (see #393) Your implementation is slightly better though 👍 |
I'm happy with this now 👍 |
Thanks for your work on this man 👍 |
I'm opening this PR now to get some feedback on implementation.
Currently, Horizon allows you to configure how long recent and failed jobs are kept for statistical purposes before being trimmed (
horizon.trim.recent
andhorizon.trim.failed
).The trouble with setting these currently is that the dashboard will always say
Jobs past hour
andFailed jobs past hour
, irrespective of the configured values.This is a first pass of making that label dynamic on the dashboard, by parsing the number of days or hours and displaying the message accordingly.
Current
Proposed
Note, I haven't compiled the CSS/JS assets.