[2.0] Handle configured 'trim' values in dashboard #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
|
This looks good but perhaps something more for 3.0 because the new methods on the |
|
Per @driesvints' comments above, I've rewritten this to be done in the |
driesvints
reviewed
Jan 10, 2019
|
This is much needed, had a bash at this myself a couple of months ago (see #393) Your implementation is slightly better though 👍 |
michaeldyrynda
changed the title
|
I'm happy with this now 👍 |
driesvints
approved these changes
Jan 11, 2019
|
Thanks for your work on this man 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR now to get some feedback on implementation.
Currently, Horizon allows you to configure how long recent and failed jobs are kept for statistical purposes before being trimmed (
horizon.trim.recentandhorizon.trim.failed).The trouble with setting these currently is that the dashboard will always say
Jobs past hourandFailed jobs past hour, irrespective of the configured values.This is a first pass of making that label dynamic on the dashboard, by parsing the number of days or hours and displaying the message accordingly.
Current
Proposed
Note, I haven't compiled the CSS/JS assets.