Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when loading monitoried tags page(#1478) #1485

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

therobfonz
Copy link
Contributor

@therobfonz therobfonz commented Aug 3, 2024

This PR fixes an issue when viewing the show page of a monitored tag

Too few arguments to function Laravel\\Horizon\\Http\\Controllers\\MonitoringController::paginate(), 1 passed in 

The underlying cause of this error is MonitoringController::paginate() was expecting the request, and a $tag parameter. Since the non-API routes are defined in Vue Router, Laravel is not resolving the {tag} parameter in the controller with route model binding.

In light of that, I added tag as a querystring parameter as well so we can grab the value with $request->query('tag').

I am not sure this is the best way to fix this, but after trying a few different ways, this seemed like the only solution.

@taylorotwell taylorotwell merged commit 184449b into laravel:5.x Aug 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants