-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] feature: this adds the vite integrity plugin to support assetsAreCurrent check #1415
Conversation
use Illuminate\Foundation\Vite as ViteFoundation; | ||
|
||
$viteDataSchemeLight = new ViteFoundation(); | ||
$viteDataSchemeLight->useStyleTagAttributes([ | ||
'data-scheme' => 'light', | ||
]); | ||
|
||
$viteDataSchemeDark = new ViteFoundation(); | ||
$viteDataSchemeDark->useStyleTagAttributes([ | ||
'data-scheme' => 'dark', | ||
]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if there is a better solution to this please tell me. currently its fairly hard (impossible) to add these kind of style tag attributes with the @Vite blade directive
…ent check fix schema -> scheme compile assets
e440755
to
0cc7e2a
Compare
@mmachatschek what would they see if the assets aren't up to date? I also thought we already had a check for this 🤔 |
@driesvints there is a file compare check here Line 195 in 3c6661d
with laravel mix we used versioning that added a hash horizon/public/mix-manifest.json Line 2 in 32ca28d
the integrity package readds this missing feature after my change from mix to vite |
This adds the manifest integrity plugin for vite to support checks if the user published the current version of the horizon assets.