-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Update to bootstrap 5.1 and drop jQuery #1405
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
b58fb67
to
9838745
Compare
@driesvints this is the resubmitted version of PR #1119 I currently don't have a full horizon setup available so I can not test this thoroughly enough. If you are ok with that, I could leave it open to others to pick up the work and add the final touches. I explicitly set the bootstrap version to v5.1 as I originally only did the changes for boostrap v5.1, the 5.2 changes can be made in a followup PR by others. although I think maybe for v6 a complete overhaul with a new tailwind made ui is probably the way to go |
Hey @mmachatschek. Thank you for your efforts. I unfortunately also don't have the time atm. Would be great if anyone could help out here. |
Popper.js is needed for tooltips, using the browser native title attribute removes the need to keep this
a0966b0
to
bc0213c
Compare
@driesvints i setup two basic laravel horizon apps on my side and pointed to the same horizon process just with different published versions of the ui. The visual comparison is fairly the same (after some tiny modifications) now. Generally bootstrap made the ui a little bit denser so thats kind of a good point. From my side its now ready for review |
8b0f692
to
ab40b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmachatschek thanks for your efforts!
@mmachatschek might be a bit too much for you but any chance you can undo all of these indenting changes in the vue files etc? Would make this PR a whole lot smaller and easier to review. |
@driesvints sorry about that, VScode applies auto formatting. I convert the PR to draft and reapply the changes. A checked-in prettier config would be nice so that editors automatically pick that up and don't mess up the code |
@mmachatschek yeah we don't have a default one because we don't use prettier directly but styleci |
1f5db02
to
703da3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is a good update. Thanks @mmachatschek
This is the backported version of PR #1119
Visual comparison:
Before:
After:
before:
![Bildschirmfoto 2024-04-04 um 21 31 27](https://private-user-images.githubusercontent.com/10237069/319749375-9e1f8f23-21cf-49d6-8fc1-817d2ed54c7d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMDIzODksIm5iZiI6MTcyNjEwMjA4OSwicGF0aCI6Ii8xMDIzNzA2OS8zMTk3NDkzNzUtOWUxZjhmMjMtMjFjZi00OWQ2LThmYzEtODE3ZDJlZDU0YzdkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDAwNDgwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZmMWFkOWU3Yzg5ZDI0YjIwMTE1NTUxMDM2MjhlMDM5N2MzY2YxMGUzNzMwZThiYzEwZDNjYWYxNzg0OTAxMzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Q-MrLnKw_bNdM-0Haean6pvOFhsH0wJZPRQME0qiSUo)
after:
before:
after: