[5.x] Make commands lazy #1399
Merged
[5.x] Make commands lazy #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
timacdonald
force-pushed
the
command-attribute
branch
from
f543793
to
9126ada
Compare
timacdonald
commented
Mar 19, 2024
| @@ -52,7 +54,6 @@ protected function registerHorizonServiceProvider() | |||
| $namespace = Str::replaceLast('\\', '', $this->laravel->getNamespace()); | |||
|
|
|||
| if (file_exists($this->laravel->bootstrapPath('providers.php'))) { | |||
| // @phpstan-ignore-next-line | |||
There was a problem hiding this comment.
PHPStan in CI was complaining that it didn't need this.
https://github.com/laravel/horizon/actions/runs/8335290386/job/22810504345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see laravel/framework#50617