Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use available batch.processedJobs value from Illuminate\Bus\Batch #1315

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

crynobone
Copy link
Member

fixes #1311

crynobone and others added 2 commits September 12, 2023 13:43
fixes #1311

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell
Copy link
Member

I see this marks #1311 as complete but that issue is primarily about the "pending" job count?

@crynobone
Copy link
Member Author

crynobone commented Sep 12, 2023

@taylorotwell Based on the previous PR to "Completed Jobs" the value of "Pending" and "Failed" with allowFailures() does make sense as discussed in #1063 (comment) so I don't think we should mess with it at the moment.

This changes just make it inline with the stored value captured in Illuminate\Bus\Batch.

@taylorotwell taylorotwell merged commit 6eaf4ef into 5.x Sep 12, 2023
2 checks passed
@taylorotwell taylorotwell deleted the fixes-1311 branch September 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending job number seems incorrect
3 participants