Respect the prefers-color-scheme setting #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good step but maybe we should take it further and add a toggle like on the Laravel docs so people can choose either light, dark or system preferences? |
|
Agreed, it would offer a lot more flexibility |
|
Can you add a screenshot how this looks? |
|
This is how it currently looks: |
|
I'd personally remove the background but other than that lgtm. Thanks! |
driesvints
approved these changes
May 18, 2023
|
LGTM - thanks 👍 |
|
Maybe adding |
lloricode
added a commit
to lloricode/horizon
that referenced
this pull request
May 27, 2023
taylorotwell
pushed a commit
that referenced
this pull request
May 29, 2023
* Mask as deprecated using `night()` and `$useDarkTheme` This PR is for #1275 * Try to fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the layout file to include media attributes on the CSS files in order to respect the
prefers-color-scheme-setting. The style of Horizon will therefore be determined by the preference of the user. Developers who prefer Horizon in light mode are not affected by theHorizon::night()method anymore.Note that the
nightmethod has not been removed to prevent a breaking change.