[5.x] Remove Lodash #1246
Merged
[5.x] Remove Lodash #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for taking care of this! we were happy to see the bundle savings in our projects, as well. want to handle it for Telescope too? https://github.com/laravel/telescope/blob/4.x/package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention of this PR was to change the Lodash imports to just pull in the functions we're actually using in order to avoid importing the unused function causing #1245 and to reduce the bundle size.
It then became apparent that we didn't actually need Lodash in most places, so I removed it altogether. This shaved 70KB from the minified bundle.