Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Implement Silenced interface #1236

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[5.x] Implement Silenced interface #1236

merged 1 commit into from
Jan 16, 2023

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 16, 2023

This PR implements a new Silenced contract that, once applied to a job, will automatically silence it and move it to the Silenced tab. This is handy for packages so they can silence their jobs by default.

@driesvints driesvints changed the title Implement Silenced interface [5.x] Implement Silenced interface Jan 16, 2023
@taylorotwell taylorotwell merged commit 355ff05 into 5.x Jan 16, 2023
@taylorotwell taylorotwell deleted the silenced-interface branch January 16, 2023 17:46
@freekmurze
Copy link

Instead of an interface, it could also be a property or function that controls this behaviour. That way package users could override the package default (you can't override an interface).

@driesvints
Copy link
Member Author

@freekmurze problem is that the job isn't resolved at the time it gets marked as completed. We have a class string to inspect. We'd need to do some reflection magic I think in order to get that to work. Do you know how to do that?

@lioneaglesolutions
Copy link
Contributor

@freekmurze @driesvints I just added #1238 - no idea if it's close enough but tests pass... happy to take feedback or close it if it isn't where it needs to be for the method override. I would assume you could do the same thing with a public property easily enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants