Make horizon work with strict content-security-policy #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit 801506b.
driesvints
added a commit
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Horizon does not work with a strict CSP (if
unsafe-evalis not allowed). This keeps coming up every once in a while. See #1128 for the latest issue.This PR fixes this by moving the main horizon container to a separate Vue component. I have tried this before (#1022), but my old PR failed to account for
autoLoadNewEntries()inbase.js, which usedthis.autoLoadsNewEntries, wherethisused to refer to the root Vue element. After these changesthisrefers toApp.vueinstead, and I failed to account for that.This PR fixes that mistake by using
this.$rootinbase.jsandApp.vue. So with this PR Horizon works as expected, and also with a CSP whereunsafe-evalis not allowed.