Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use callAfterResolving to register QueueManager #1089

Merged
merged 1 commit into from
Oct 19, 2021
Merged

use callAfterResolving to register QueueManager #1089

merged 1 commit into from
Oct 19, 2021

Conversation

mabdullahsari
Copy link
Contributor

Due to the nature of how our app/monolith is registering service providers (we disabled autodiscovery), the resolving listener would never trigger because of another error tracking dependency.

While serving the app via the console, HorizonServiceProvider is always registered. But when serving over HTTP, it is only registered lazily via some domain\context inference in a global middleware. At that point however, the error tracking package has already resolved the QueueManager instance causing the app to crash when trying to visit the Horizon dashboard.

Using callAfterResolving would fix our issue and not break anything for any other user, as it just adds an extra if-check under the hood.

Thank you!

@taylorotwell taylorotwell merged commit b422316 into laravel:5.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants