Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom MasterSupervisor::basename breaks horizon dashboard #618

Closed
lonnylot opened this issue Jun 20, 2019 · 0 comments · Fixed by #619, FaZeRs/laravel-portfolio#71 or stefanzweifel/laravel-download-statistics-app#20 · May be fixed by jakebathman/bathmans#19
Closed

Custom MasterSupervisor::basename breaks horizon dashboard #618

lonnylot opened this issue Jun 20, 2019 · 0 comments · Fixed by #619, FaZeRs/laravel-portfolio#71 or stefanzweifel/laravel-download-statistics-app#20 · May be fixed by jakebathman/bathmans#19

Comments

@lonnylot
Copy link
Contributor

  • Horizon Version: 3.1.2
  • Laravel Version: 5.7.28
  • PHP Version: 7.2.19
  • Redis Driver & Version: predis/phpredis 1.1.1
  • Database Driver & Version: MySQL 5.7.23

Description:

If the MasterSupervisor::basename() contains an extra ':' then the RedisSupervisorRepository::update will set the wrong master field.

Steps To Reproduce:

  1. Set your app/Providers/HorizonServiceProviders.php as shown here
  2. Navigate to the horizon/dashboard route in your browser and you will see the supervisor section is empty
lonnylot added a commit to lonnylot/horizon that referenced this issue Jun 20, 2019
@lonnylot
Fixes laravel#618
9b5601d
lonnylot added a commit to lonnylot/horizon that referenced this issue Jun 20, 2019
@lonnylot
Fixes laravel#618
2bc4b63
@lonnylot lonnylot mentioned this issue Jun 20, 2019
Merged
This was referenced Jun 25, 2019
Closed
Merged
Closed
Merged
This was referenced Jul 2, 2019
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@lonnylot