Merge pull request #515 from driesvints/fix-deprecated-process-calls

[3.0] Fix deprecated process calls
laravel · Feb 21, 2019 · 4343051 · 4343051
2 parents 374ab3c + 3055cdc
commit 4343051
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/MasterSupervisorCommands/AddSupervisor.php b/src/MasterSupervisorCommands/AddSupervisor.php
@@ -38,7 +38,7 @@ protected function createProcess(MasterSupervisor $master, SupervisorOptions $op
     {
         $command = $options->toSupervisorCommand();
 
-        return (new Process($command, $options->directory ?? base_path()))
+        return Process::fromShellCommandline($command, $options->directory ?? base_path())
                     ->setTimeout(null)
                     ->disableOutput();
     }

diff --git a/src/ProcessPool.php b/src/ProcessPool.php
@@ -179,8 +179,8 @@ protected function createProcess()
                     ? BackgroundProcess::class
                     : Process::class;
 
-        return new WorkerProcess((new $class(
-            $this->options->toWorkerCommand(), $this->options->directory)
+        return new WorkerProcess($class::fromShellCommandline(
+            $this->options->toWorkerCommand(), $this->options->directory
         )->setTimeout(null)->disableOutput());
     }
 

diff --git a/src/SystemProcessCounter.php b/src/SystemProcessCounter.php
@@ -21,7 +21,7 @@ class SystemProcessCounter
      */
     public function get($name)
     {
-        $process = new Process('exec ps aux | grep '.static::$command, null, ['COLUMNS' => '2000']);
+        $process = Process::fromShellCommandline('exec ps aux | grep '.static::$command, null, ['COLUMNS' => '2000']);
 
         $process->run();
 

diff --git a/tests/Feature/WorkerProcessTest.php b/tests/Feature/WorkerProcessTest.php
@@ -16,7 +16,7 @@ public function test_worker_process_fires_event_if_stopped_process_cant_be_resta
     {
         Event::fake();
 
-        $process = new Process('exit 1');
+        $process = new Process(['exit', 1]);
         $workerProcess = new WorkerProcess($process);
         $workerProcess->start(function () {
         });
@@ -31,7 +31,7 @@ public function test_process_is_not_restarted_during_cooldown_period()
     {
         Event::fake();
 
-        $process = new Process('exit 1');
+        $process = new Process(['exit', 1]);
         $workerProcess = new WorkerProcess($process);
         $workerProcess->start(function () {
         });
@@ -47,7 +47,7 @@ public function test_process_is_restarted_after_cooldown_period()
     {
         Event::fake();
 
-        $process = new Process('exit 1');
+        $process = new Process(['exit', 1]);
         $workerProcess = new WorkerProcess($process);
         $workerProcess->start(function () {
         });