[9.x] Add giveConfig to ContextualBindingBuilder #39819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #36241. I had intended to work on the contract eventually and thought maybe it would just get added eventually by someone else.
This afternoon I decided to go ahead and add it. In the process, I discovered I'm not the first to send a PR for this addition! Unfortunately, both #36361 and #38925 were rejected.
I'm going to send my PR anyway to open the discussion again. In my initial PR, it was not stated that this was syntactical sugar that would never make it to the contract. Similar to
giveTagged
in #32514, I fully expected we'd be able to get this into the contract eventually.Going to bring this discussion up in Discord, too. :)
Ultimately, nobody will ever be able to discover this method exists and probably shouldn't be relying on it being available: