Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing giveConfig method in ContextualBindingBuilder #36361

Closed
wants to merge 2 commits into from
Closed

Add missing giveConfig method in ContextualBindingBuilder #36361

wants to merge 2 commits into from

Conversation

ahmadmayahi
Copy link
Contributor

Add missing giveConfig method in ContextualBindingBuilder interface.

@ahmadmayahi ahmadmayahi changed the title Add missing giveConfig method Add missing giveConfig method in ContextualBindingBuilder Feb 23, 2021
@driesvints
Copy link
Member

Unfortunately this is a breaking change for any implementation implementing this contract.

@driesvints driesvints closed this Feb 23, 2021
@driesvints
Copy link
Member

Also: the giveConfig is syntactical sugar and not necessary for this contract.

@ahmadmayahi
Copy link
Contributor Author

That makes sense, thanks for clarification.

@denniscoorn-paqt denniscoorn-paqt mentioned this pull request Sep 23, 2021
Closed
@simensen simensen mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadmayahi @driesvints