[5.5] Fixes application console method run

[nunomaduro]

This PR address an issue introduced on Laravel 5.5.

In the usage of the public method run, before we could actually use null as input and output. Since the Symfony's method run creates a default input and output.

Since now we are managing our run method we need to also create default values, in order to don't touch on the API of this method.

[themsaid]

What issue does this PR fix? nothing seems to be broken and the method calls parent::run which creates the input/output instances as before

[nunomaduro]

@themsaid It fixes illuminate/console component usage of the method run without default input/output. On Laravel that don't happens, because we pass all the time an valid input/output. Other packages may trust on the definition of the api of the method and pass null.

Right now, if we pass null on both params, the code will not run and will break on the following places:

Line 76:

$commandName = $this->getCommandName($input);

Error: ... must be an instance of Symfony\Component\Console\Input\InputInterface, null given.

Line 78:

        $this->events->fire(
            new Events\CommandStarting($commandName, $input, $output)
        ); 

Error: PHP Fatal error: Uncaught TypeError: Argument 3 passed to Illuminate\Console\Events\CommandStarting::__construct() must implement interface Symfony\Component\Console\Output\OutputInterface, null given.

[themsaid]

I see, thanks for explaining :)

[paulofreitas]

Commit b26a9fa overloaded the run() method to introduce the new console events. Symfony will still handle this itself, but the new console events require an InputInterface instance themselves.

Since Laravel 5.5 was now released changing the new console events signature to be nullable would certainly be a breaking change (it depends on BC promises), so for now it's safest to handle this early and postpone the interface signature change to the next major release. 👍