[5.5] DelegatesToResource: fix offsetExists. #20887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themsaid
reviewed
Aug 31, 2017
| @@ -46,7 +46,7 @@ public function resolveRouteBinding($value) | |||
| */ | |||
| public function offsetExists($offset) | |||
| { | |||
| return array_key_exists($this->resource[$offset]); | |||
| return array_key_exists($this->resource, $offset); | |||
There was a problem hiding this comment.
Also I believe you mean:
return array_key_exists($offset, $this->resource);
There was a problem hiding this comment.
Good catch, fixed: c907481
There was a problem hiding this comment.
In all seriousness - why did the tests not catch that error?
|
yeah @laurencei - some lack happens sometimes 😎 - and we can find some code errors sometimes |
Ellrion
added a commit
to Ellrion/framework
that referenced
this pull request
Sep 1, 2017
This reverts commit b87ac8d.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DelegatesToResource: fix offsetExists.