-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to support PHP 8 #421
Conversation
cc @owenvoke |
@hmazter, is there any chance you could tag a release of Laravel Schedule List with PHP 8 support? 🙂 |
Sorry, thought that I already had. Will fix it in 2 hours. 😄 |
No problem, thank you! |
v2.2.1 tagged https://packagist.org/packages/hmazter/laravel-schedule-list#v2.2.1 |
@owenvoke Let me know If I can help here. |
I think Box is the only thing we are waiting on now. 👍 I'm going to have a check through the internal framework code to check that's all compatible as well. |
We should be good on that regard, as we have some tests. And if something is not good, the community can report and we patch it. So we need to wait for box now... |
Right, Box v3.11.0 is now released which adds PHP 8 support. I will add this in and try to aim for a release soon. 👍 |
7a3af48
to
f71ee3c
Compare
Is this perhaps another dependency that needs to be updated for php8?: see: "php": "^7.2.5" With a dependency on
|
@bhamail, Tinker Zero isn't an official package so they'd have to add support over there. Feel free to open a PR on their repository, or I'll PR it tomorrow. |
@owenvoke Cool. Thanks! Just in case others hit a similar issue, in my case, we don't need |
I've opened a PR over at intonate/tinker-zero#8, so hopefully that can get merged. 👍🏻 Anyway, glad you got it sorted. |
It looks like the following also need to be updated to support PHP 8 upstream.
laminas/laminas-servicemanager
(It's had support for ages, I just misread the repository)ramsey/uuid
(looks like it now supports PHP 8 in master, but waiting on a release)nunomaduro/laravel-console-dusk
(waiting on new Laravel Dusk and PHP Webdriver releases)hmazter/laravel-schedule-list
(waiting on a new tag, support is available inmaster
)The packaged Box binary underbin/
(Support PHP8 box-project/box#486) once they create a new PHAR releaseWe will also want to update the Updater component to use the new Laravel Zero fork of PHAR Updater.