Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP8 #486

Closed
ptondereau opened this issue Oct 3, 2020 · 6 comments · Fixed by #508
Closed

Support PHP8 #486

ptondereau opened this issue Oct 3, 2020 · 6 comments · Fixed by #508

Comments

@ptondereau
Copy link

ptondereau commented Oct 3, 2020 •
edited
Loading

Feature Request

Does it have any plan to support PHP8?
Do you think it should be OK with enabling PHP8.0 on CI and update composer.json?
@ptondereau ptondereau mentioned this issue Oct 3, 2020
Closed
@villfa
Copy link
Contributor

villfa commented Oct 5, 2020

Some dependencies don't support PHP-8 yet:

Furthermore to run the tests with PHP-8 they must be compatible with PHPUnit 9.3.
Probably the best way to achieve that is to use symfony/phpunit-bridge (it is already a dependency but it is not used to run the tests).

@ptondereau
Copy link
Author

beberlei/assert#302

@owenvoke owenvoke mentioned this issue Nov 17, 2020
Merged
@hanneskod hanneskod mentioned this issue Nov 30, 2020
Open
4 tasks
@owenvoke owenvoke mentioned this issue Dec 1, 2020
Merged
@smoench
Copy link
Contributor

smoench commented Dec 2, 2020

I started to add PHP 8 support for php-scoper humbug/php-scoper#446

I think it would time to fork paragonie/pharaoh as it is not in active development nor getting feedback from the maintainers.

@villfa
Copy link
Contributor

villfa commented Dec 2, 2020

I think it would time to fork paragonie/pharaoh as it is not in active development nor getting feedback from the maintainers.

@theofidry Since you're alone to maintain box and php-scoper I'm curious to know your opinion about that.

@ramsey ramsey mentioned this issue Dec 3, 2020
Closed
@villfa
Copy link
Contributor

villfa commented Dec 3, 2020

@smoench here: https://github.com/paragonie/pharaoh/releases/tag/v0.6.0

@smoench smoench mentioned this issue Dec 3, 2020
Merged
@smoench
Copy link
Contributor

smoench commented Dec 7, 2020

https://github.com/beberlei/assert/releases/tag/v3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add PHP 8 support smoench/box
3 participants
@smoench @villfa @ptondereau