Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .nvmrc with minimum supported Node version #703

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

jameshfisher
Copy link
Contributor

I had some mysterious failures with examples due to using Node 16. With an nvmrc to auto-switch to Node 18, I would have avoided this mistake.

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
langchainjs-docs ⬜️ Ignored (Inspect) Apr 10, 2023 8:46am

@nfcampos
Copy link
Collaborator

Thanks! Should this instead be node to default to the latest (19)?

@nfcampos nfcampos added the question Further information is requested label Apr 10, 2023
@jameshfisher
Copy link
Contributor Author

@nfcampos yes, if you prefer! I wish .nvmrc would let you specify e.g. v18+, but I don't think it's possible. But I've always set .nvmrc to the minimum supported Node version (18 in this project), so that developers don't accidentally assume newer features.

@nfcampos
Copy link
Collaborator

Cool lets leave as is

@nfcampos nfcampos merged commit 8af83fb into langchain-ai:main Apr 10, 2023
@nfcampos nfcampos removed the question Further information is requested label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants