feat(langchain): Rerank Documents Based on Recency Bias on Document Date in Metadata #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:L
Mraj23
changed the title
jacoblee93
reviewed
Sep 4, 2024
jacoblee93
reviewed
Sep 4, 2024
jacoblee93
reviewed
Sep 4, 2024
jacoblee93
changed the title
jacoblee93
reviewed
Sep 10, 2024
| ): [Document, number][] { | ||
| if (documents.length === 0) return []; | ||
|
|
||
| if (!documents.every(([doc, _]) => doc.metadata.date instanceof Date)) { |
There was a problem hiding this comment.
Would suggest storing this as an ISO string - not all (most?) vector stores will not deserialize dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue): langchain-ai/langchain#18729
This PR implements a retriever that performs reranking based on receny of a documents published date.
This retreiver differs from the
TimeWeightedVectorStoreRetrieverthat performs retrieval based on the retrieved date of the document, not its published date