Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update score_threshold.ts #6671

Closed
wants to merge 1 commit into from
Closed

Conversation

emehmet
Copy link

@emehmet emehmet commented Sep 1, 2024

fix: Updated ScoreThresholdRetriever to filter results with scores below the minimum similarity score

Fixes # (issue)

feat: Update ScoreThresholdRetriever to filter results with scores below the minimum similarity score
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 1, 2024
Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2024 0:54am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Sep 1, 2024 0:54am

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Sep 1, 2024
@jacoblee93
Copy link
Collaborator

jacoblee93 commented Sep 3, 2024

Thanks for the PR!

This is breaking - we could add a way to specify sort order though!

@jacoblee93 jacoblee93 added the question Further information is requested label Sep 3, 2024
@jacoblee93 jacoblee93 closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases question Further information is requested size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants