Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Remote.js fix fetch implementation #6529

Closed
wants to merge 6 commits into from
Closed

core[patch]: Remote.js fix fetch implementation #6529

wants to merge 6 commits into from

Conversation

mcgear
Copy link
Contributor

@mcgear mcgear commented Aug 14, 2024

Fixes issue# (6527)

Simple adjustment to make sure fetch maintains its default binding.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 14, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 14, 2024 2:17pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Aug 14, 2024 2:17pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Aug 14, 2024
@jacoblee93
Copy link
Collaborator

Hey @mcgear! Thanks for the PR. How would this pop up exactly?

Would it be if you bound something to the fetch global and overrode it?

@jacoblee93 jacoblee93 changed the title Remote.js fix fetch implementation core[patch]: Remote.js fix fetch implementation Aug 15, 2024
@jacoblee93 jacoblee93 mentioned this pull request Aug 15, 2024
Merged
jacoblee93 added a commit that referenced this pull request Aug 15, 2024
@jacoblee93 @mcgear
Fix remote runnable in browser environments (Extends #6529) (#6537)
4425d27 
* stream to streamEvents

* Fetch impl fix

* switch back

* switch back

* Fix

* Comment

---------

Co-authored-by: mcgear <michael.gearhardt@gmail.com>
Co-authored-by: Michael Gearhardt <michael.gearhardt@fathym.com>
@jacoblee93
Copy link
Collaborator

Merged in #6537, thank you!

@jacoblee93
Copy link
Collaborator

Live in core@0.2.24, thanks again!

@jacoblee93 jacoblee93 closed this Aug 15, 2024
@sindhuhack sindhuhack mentioned this pull request Aug 29, 2024
Open
@hatart hatart mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 7, 2024
Closed
Merged
@bruno353 bruno353 mentioned this pull request Sep 9, 2024
Open
@lholmquist lholmquist mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcgear @jacoblee93