core[patch]: Remove signal event listener when completed #6497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:M
nfcampos
reviewed
Aug 12, 2024
| @@ -14,13 +15,14 @@ export async function raceWithSignal<T>( | |||
| } | |||
| }), | |||
| new Promise<never>((_, reject) => { | |||
| signal.addEventListener("abort", () => { | |||
| listener = () => { | |||
| reject(new Error("Aborted")); | |||
There was a problem hiding this comment.
I think the remove call should be inside the listener?
There was a problem hiding this comment.
Could add it in both places but it should be removed once the promise resolves too?
What's the benefit to putting it within the listener vs. in finally?
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #6461, though if more than 10 runnables in a chain run in parallel this warning will likely resurface.
CC @nfcampos