Extends 6413 #6452
Merged
Extends 6413 #6452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
| * @returns A new instance of `PGVectorStore`. | ||
| */ | ||
| static async initialize( | ||
| embeddings: EmbeddingsInterface, | ||
| config: PGVectorStoreArgs | ||
| config: PGVectorStoreArgs & { dimensions?: number } |
There was a problem hiding this comment.
Would it make sense to add the optional dimensions to the PGVectorStoreArgs type directly? 🤔
There was a problem hiding this comment.
Yeah I can now see how it's not convenient - I can just make the constructor Omit dimensions
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #6413
CC @clemenspeters