mongodb[patch]: Fix bug in mongodb storage.ts #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving records the value was always JSON.stringified even if the value was already in JSON. As a result, MongoStore could not be used with standard retrievers like the ParentRetriever as it would always return documents with undefined for pageContent.
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
jacoblee93
changed the title
jacoblee93
approved these changes
Aug 3, 2024
|
Thanks! Cutting a new patch release now! |
|
Live here: https://www.npmjs.com/package/@langchain/mongodb Thanks again! |
|
Your welcome. Thanks for the fast merge! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving records from MongoDBStore the value was always JSON.stringified even if the value was already in JSON. As a result, MongoDBStore does not work with standard retrievers like the ParentRetriever as it would always return documents with undefined for pageContent. This corrects that behavior by look at the value and only JSON.stringify if it is an Object. If it is a string then it just returns the value as is.