Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-common[patch]: Add method property to GoogleAISafetySetting interface #6310

Merged
merged 3 commits into from
Aug 2, 2024
Merged

google-common[patch]: Add method property to GoogleAISafetySetting interface #6310

merged 3 commits into from
Aug 2, 2024

Conversation

marsal
Copy link
Contributor

@marsal marsal commented Aug 1, 2024 •
edited by bracesproul
Loading

Fixes #6309

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 8:59am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 2, 2024 8:59am

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Aug 1, 2024
bracesproul
bracesproul approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, thanks for adding this!

libs/langchain-google-common/src/types.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Aug 1, 2024
bracesproul
bracesproul requested changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I can't push changes to your branch, could you commit that suggested change? Then I can merge.

@dosubot dosubot bot removed the lgtm PRs that are ready to be merged as-is label Aug 1, 2024
@bracesproul bracesproul changed the title feat: Add method property to GoogleAISafetySetting interface google-common[patch]: Add method property to GoogleAISafetySetting interface Aug 1, 2024
@marsal marsal requested a review from bracesproul August 2, 2024 05:51
bracesproul
bracesproul approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Aug 2, 2024
@bracesproul bracesproul merged commit dead673 into langchain-ai:main Aug 2, 2024
27 checks passed
@marsal marsal deleted the fix-add-method-attribute-to-safetty-settings branch August 19, 2024 05:53
@prathik2401 prathik2401 mentioned this pull request Aug 29, 2024
Merged
@riderx riderx mentioned this pull request Aug 29, 2024
Open
@sindhuhack sindhuhack mentioned this pull request Aug 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VertexAI doesn't allow safetySettings param method
2 participants
@marsal @bracesproul